From b19f595daff1252eec44686751ea509ecbad7e92 Mon Sep 17 00:00:00 2001
From: DcruBro <info@dcrubro.com>
Date: Sat, 14 Mar 2026 19:11:59 +0100
Subject: [PATCH] Audio fix

---
 include/audio/audio.hpp   |  4 +--
 include/object/sound.hpp  |  1 +
 include/window/window.hpp |  6 ++++
 src/game/agame/player.cpp | 13 ++++++--
 src/object/sound.cpp      | 66 ++++++++++++++++++++-------------------
 src/window/window.cpp     | 14 +++++++++
 6 files changed, 67 insertions(+), 37 deletions(-)

diff --git a/include/audio/audio.hpp b/include/audio/audio.hpp
index e45cd37..7984823 100644
--- a/include/audio/audio.hpp
+++ b/include/audio/audio.hpp
@@ -15,7 +15,7 @@ namespace Game::Audio {
             SDL_AudioDeviceID getAudioDevice() const { return mDevice; }
         
         private:
-            SDL_AudioSpec mAudioSpec;
-            SDL_AudioDeviceID mDevice;
+            SDL_AudioSpec mAudioSpec{};
+            SDL_AudioDeviceID mDevice = 0;
     };
 };
\ No newline at end of file
diff --git a/include/object/sound.hpp b/include/object/sound.hpp
index b1c292f..2177b9d 100644
--- a/include/object/sound.hpp
+++ b/include/object/sound.hpp
@@ -32,6 +32,7 @@ namespace Game::Object {
             Uint8* mAudioBuffer = nullptr;
             Uint32 mAudioLength = 0;
             SDL_AudioStream* mAudioStream = nullptr;
+            SDL_AudioSpec mSourceSpec{};
             int mVolume;
     };
 }
\ No newline at end of file
diff --git a/include/window/window.hpp b/include/window/window.hpp
index ef32156..832303f 100644
--- a/include/window/window.hpp
+++ b/include/window/window.hpp
@@ -10,6 +10,7 @@
 #include <state/gamestate.hpp>
 #include <game/gamemanager.hpp>
 #include <audio/audio.hpp>
+#include <chrono>
 
 namespace Game::Window {
     class Window {
@@ -24,14 +25,19 @@ namespace Game::Window {
             void setTargetFPS(int fps) { mTargetFPS = fps; }
             int getTargetFPS() { return mTargetFPS; }
 
+            static SDL_Window* getSDLWindowBackend() { return sWindowBackend; }
+
             Renderer::Renderer* getRenderer() { return &mRenderer; }
 
         private:
+            static inline SDL_Window* sWindowBackend = nullptr;
             SDL_Window* mWindow;
             Renderer::Renderer mRenderer;
             Game::GameManager mGameManager;
             std::jthread mGameThread;
             bool mRunning;
             int mTargetFPS = 60;
+            size_t mFrameCount = 0;
+            std::chrono::steady_clock::time_point mLastFPSTime;
     };
 }
\ No newline at end of file
diff --git a/src/game/agame/player.cpp b/src/game/agame/player.cpp
index c51c865..1e35517 100644
--- a/src/game/agame/player.cpp
+++ b/src/game/agame/player.cpp
@@ -1,13 +1,20 @@
 #include <game/agame/player.hpp>
+#include <window/window.hpp>
+#include <cmath>
 
 namespace Game::AGame {
     void Player::start() {
         mSound = Object::Sound("../resources/example.wav", Object::Format::WAV);
         mSound.play();
+        
+        int w, h;
+        SDL_GetWindowSizeInPixels(Window::Window::getSDLWindowBackend(), &w, &h);
 
-        mTransform.x = 640.f - (mTex->getWidth() / 2.f * mTransform.scaleX); // Start in the middle of the screen
-        mTransform.y = 360.f - (mTex->getHeight() / 2.f * mTransform.scaleY);
+        mTransform.x = w / 2.f - (mTex->getWidth() / 2.f * mTransform.scaleX * 0.25f); // Start in the middle of the screen
+        mTransform.y = h / 2.f - (mTex->getHeight() / 2.f * mTransform.scaleY * 0.25f);
         mTransform.rotation = 0.f;
+
+        LOG("W: " << w << " H: " << h);
     }
 
     void Player::update(float deltaTime) {
@@ -18,6 +25,6 @@ namespace Game::AGame {
         //LOG(mName << " position: " << mTransform.x << ' ' << mTransform.y);
         //LOG("DeltaTime: " << deltaTime);
         mTransform.scaleX = 1.f + 1.f * std::sin(RUNNING_TIME() / 0.5f); // Pulsate scale for testing
-        //mTransform.scaleY = 1.f + 1.f * std::sin(SDL_GetTicks() / 500.f);
+        mTransform.scaleY = 1.f + 0.5f * std::cos(RUNNING_TIME() / 0.5f); // Pulsate scale for testing
     }
 }
\ No newline at end of file
diff --git a/src/object/sound.cpp b/src/object/sound.cpp
index 7a7ae61..4d174d0 100644
--- a/src/object/sound.cpp
+++ b/src/object/sound.cpp
@@ -1,37 +1,25 @@
 #include <object/sound.hpp>
 
 namespace Game::Object {
-    namespace {
-        static SDL_AudioSpec makeFloatStereo44100() {
-            SDL_AudioSpec spec{};
-            spec.freq = 44100;
-            spec.channels = 2;
-            spec.format = SDL_AUDIO_F32;
-            return spec;
-        }
-    }
-
     Sound::Sound(std::string path, Format format, int volume)
-        : mAudioBuffer(nullptr), mAudioLength(0), mAudioStream(nullptr), mVolume(volume) {
+        : mAudioBuffer(nullptr), mAudioLength(0), mAudioStream(nullptr), mSourceSpec{}, mVolume(volume) {
         if (format == Format::WAV) {
-            SDL_AudioSpec wavSpec = makeFloatStereo44100();
-
-            if (!SDL_LoadWAV(path.c_str(), &wavSpec, &mAudioBuffer, &mAudioLength)) {
+            if (!SDL_LoadWAV(path.c_str(), &mSourceSpec, &mAudioBuffer, &mAudioLength)) {
                 ERROR("Failed to load WAV file: " << SDL_GetError());
                 return;
             }
 
             LOG("WAV file loaded successfully");
 
-            SDL_AudioSpec spec = makeFloatStereo44100();
             mAudioStream = SDL_OpenAudioDeviceStream(
-                Audio::Audio::getInstance().getAudioDevice(), &spec, nullptr, nullptr
+                Audio::Audio::getInstance().getAudioDevice(), &mSourceSpec, nullptr, nullptr
             );
             if (!mAudioStream) {
                 ERROR("Failed to create audio stream: " << SDL_GetError());
                 SDL_free(mAudioBuffer);
                 mAudioBuffer = nullptr;
                 mAudioLength = 0;
+                mSourceSpec = {};
             }
         } else {
             ERROR("Unsupported audio format");
@@ -39,7 +27,7 @@ namespace Game::Object {
     }
 
     Sound::Sound(const Sound& other)
-        : mAudioBuffer(nullptr), mAudioLength(0), mAudioStream(nullptr), mVolume(other.mVolume) {
+        : mAudioBuffer(nullptr), mAudioLength(0), mAudioStream(nullptr), mSourceSpec(other.mSourceSpec), mVolume(other.mVolume) {
         if (&other == this) return;
 
         if (other.mAudioBuffer && other.mAudioLength > 0) {
@@ -53,9 +41,8 @@ namespace Game::Object {
             mAudioLength = other.mAudioLength;
         }
 
-        SDL_AudioSpec wavSpec = makeFloatStereo44100();
         mAudioStream = SDL_OpenAudioDeviceStream(
-            Audio::Audio::getInstance().getAudioDevice(), &wavSpec, nullptr, nullptr
+            Audio::Audio::getInstance().getAudioDevice(), &mSourceSpec, nullptr, nullptr
         );
         if (!mAudioStream) {
             ERROR("Failed to create audio stream for copied Sound: " << SDL_GetError());
@@ -78,10 +65,8 @@ namespace Game::Object {
             newLength = other.mAudioLength;
         }
 
-        SDL_AudioStream* newStream = nullptr;
-        SDL_AudioSpec wavSpec = makeFloatStereo44100();
-        newStream = SDL_OpenAudioDeviceStream(
-            Audio::Audio::getInstance().getAudioDevice(), &wavSpec, nullptr, nullptr
+        SDL_AudioStream* newStream = SDL_OpenAudioDeviceStream(
+            Audio::Audio::getInstance().getAudioDevice(), &other.mSourceSpec, nullptr, nullptr
         );
         if (!newStream) {
             ERROR("Failed to create audio stream for copied Sound: " << SDL_GetError());
@@ -95,20 +80,23 @@ namespace Game::Object {
         mAudioBuffer = newBuffer;
         mAudioLength = newLength;
         mAudioStream = newStream;
+        mSourceSpec = other.mSourceSpec;
         mVolume = other.mVolume;
 
         return *this;
     }
 
-    Sound::Sound(Sound&& other)
-        : mAudioBuffer(other.mAudioBuffer),
-          mAudioLength(other.mAudioLength),
-          mAudioStream(other.mAudioStream),
-          mVolume(other.mVolume) {
-        other.mAudioBuffer = nullptr;
-        other.mAudioLength = 0;
-        other.mAudioStream = nullptr;
-    }
+        Sound::Sound(Sound&& other)
+                : mAudioBuffer(other.mAudioBuffer),
+                    mAudioLength(other.mAudioLength),
+                    mAudioStream(other.mAudioStream),
+                    mSourceSpec(other.mSourceSpec),
+                    mVolume(other.mVolume) {
+                other.mAudioBuffer = nullptr;
+                other.mAudioLength = 0;
+                other.mAudioStream = nullptr;
+                other.mSourceSpec = {};
+        }
 
     Sound& Sound::operator=(Sound&& other) {
         if (this != &other) {
@@ -118,11 +106,13 @@ namespace Game::Object {
             mAudioBuffer = other.mAudioBuffer;
             mAudioLength = other.mAudioLength;
             mAudioStream = other.mAudioStream;
+            mSourceSpec = other.mSourceSpec;
             mVolume = other.mVolume;
 
             other.mAudioBuffer = nullptr;
             other.mAudioLength = 0;
             other.mAudioStream = nullptr;
+            other.mSourceSpec = {};
         }
         return *this;
     }
@@ -142,8 +132,20 @@ namespace Game::Object {
 
     void Sound::play() {
         if (mAudioStream && mAudioBuffer && mAudioLength > 0) {
+            SDL_ClearAudioStream(mAudioStream);
+
             if (!SDL_PutAudioStreamData(mAudioStream, mAudioBuffer, mAudioLength)) {
                 ERROR("Failed to queue audio data: " << SDL_GetError());
+                return;
+            }
+
+            if (!SDL_FlushAudioStream(mAudioStream)) {
+                ERROR("Failed to flush audio stream: " << SDL_GetError());
+                return;
+            }
+
+            if (!SDL_ResumeAudioStreamDevice(mAudioStream)) {
+                ERROR("Failed to resume audio stream device: " << SDL_GetError());
             }
         }
     }
diff --git a/src/window/window.cpp b/src/window/window.cpp
index 505e54f..f3c31e0 100644
--- a/src/window/window.cpp
+++ b/src/window/window.cpp
@@ -16,6 +16,7 @@ namespace Game::Window {
         if (mWindow) {
             SDL_DestroyWindow(mWindow);
             mWindow = nullptr;
+            sWindowBackend = nullptr;
             LOG("Window destroyed successfully");
         }
         SDL_Quit();
@@ -41,12 +42,14 @@ namespace Game::Window {
             SDL_Quit();
             return false;
         }
+        sWindowBackend = mWindow;
 
         LOG("Window created successfully");
 
         if (!mRenderer.init(mWindow)) {
             SDL_DestroyWindow(mWindow);
             mWindow = nullptr;
+            sWindowBackend = nullptr;
             SDL_Quit();
             return false;
         }
@@ -77,6 +80,17 @@ namespace Game::Window {
 
             mRenderer.renderFrame();
             SDL_Delay(1000 / mTargetFPS); // Delay to cap the frame rate to the target FPS
+
+            // Set the window title to show the current FPS for testing
+            mFrameCount++;
+            auto now = std::chrono::steady_clock::now();
+            auto elapsed = std::chrono::duration_cast<std::chrono::seconds>(now - mLastFPSTime).count();
+            if (elapsed >= 1) {
+                int fps = static_cast<int>(mFrameCount / elapsed);
+                SDL_SetWindowTitle(mWindow, ("Game Window - FPS: " + std::to_string(fps)).c_str());
+                mFrameCount = 0;
+                mLastFPSTime = now;
+            }
         }
     }
 }
\ No newline at end of file