Fix multi-homed / IPv6 peer identity: nodes adding themselves and reconnect churn

Root cause: peers were keyed only by (IP, listen port). An IPv6 host holds several addresses at once, so one node appeared as several peers and could not recognise its own addresses.

Protocol:
 - Added a random per-run node identity (localNodeId), advertised as a length-guarded trailing field in HELLO and ACK_HELLO — backwards compatible with peers that omit it
 - Added peerNodeId to tcp_connection_t; peers are now identified by this rather than by an endpoint
 - ACK_HELLO is now sent before any decision to drop the connection, so a rejected dialer learns whose address it reached instead of retrying forever

Self-connection:
 - Identity match → close the connection and record that endpoint permanently as our own
 - Self-endpoint set preemptively seeded from getifaddrs() at startup, so a node knows its own addresses before ever dialing one
 - Node_ConnectPeer refuses self endpoints, which also kills the echo-back chain that could exhaust connection slots

Duplicate connections and churn:
 - Dedup by identity per direction — one inbound and one outbound per physical peer, regardless of how many addresses it has
 - Moved dial history out of the peer table, so striking a peer no longer resets its connect-retry cooldown (this was the loop engine: strike → re-learn via gossip → redial next tick)
 - Node_HasOtherInboundFrom / Node_HasLiveConnectionTo now ignore connections that are already tearing down, and match on identity as well as endpoint

Gossip hygiene:
 - Never hand a peer its own other addresses in a PEERS reply (matched on identity, not just the socket address)
 - Reject unusable endpoints: link-local without scope id, unspecified, multicast, site-local (loopback stays allowed for local testing)
 - Normalise IPv4-mapped IPv6 so one host cannot occupy two entries

Two bugs found along the way:
 - All nodes drew the same identity — random_eight_byte() comes from srand(time(NULL)), so processes started in the same second produced identical values. Added random_secure_eight_byte() (/dev/urandom) for the identity, and mixed the pid into the seed so connection IDs stop colliding too
 - Identity dedup initially left inbound-only nodes mute — broadcasts traverse outbound connections only, so suppressing a dial-back because an inbound existed would have silenced such a node. Corrected to per-direction

Other:
 - peers output now shows each entry's node identity and the node's own endpoints
 - Added _DEFAULT_SOURCE to the build so getifaddrs() stays visible on glibc

This commit is contained in:

dcrubro

2026-07-27 14:08:57 +02:00

parent 5aa99ecb01

commit 0e90f7d5db

10 changed files with 531 additions and 48 deletions

									
										include/tcpd/tcpconnection.h
									
		+5
		
												View File
												
				@@ -31,6 +31,11 @@ struct tcp_connection_t {

				    // For OUTBOUND connections the peerAddr port already is the listen port; this matters for INBOUND peers.

				    uint16_t peerListenPort;

				    // Peer's advertised node identity (learned from HELLO/ACK_HELLO). 0 until known / peer too old

				    // to advertise one. Unlike the peer address, this is stable across all of a multi-homed peer's

				    // endpoints, so it is what identifies the node behind this connection.

				    uint64_t peerNodeId;

				    pthread_t ioThread;

				    pthread_mutex_t sendLock;

				    pthread_mutex_t stateLock;